Merge ElasticSearch tests to speed up full runs #124
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are currently 2 es tests:
basic
andcompress
.For compress it had an entirely separate elasticsearch-compress and fluentbit-compress yaml files.
Differences are as follows:
Compression:
The elasticsearch file is only different than the basic one because it specified
http.compression=true
. According to the documentation, that is already the default when you do not use https, which we do not.From the doc
Therefore while the config looks different it's not actually different, so there's no need for a second elasticsearch config artifact.
elasticsearch-compress.yaml
was removed.Fluentbit:
The only differences between these tests were the es output in fluentbit-compress.yaml config had the
compress gzip
enabled. To cut out setup/teardown times. I removed thefluentbit-compress.yaml
and added a second es OUTPUT in thefluentbit-basic.yaml
that hascompress gzip
enabled. This now writes to a 2nd index in es calledfluentbit-compress
.The basic intent here is to have a single fluentbit deployment that can attempt test sending with and without compression via 2 different outputs.
fluentbit-compress.yaml
was removed.The tests:
The only differences from the tests themselves is that the compressed version added a
--compressed
flag to the curl to request a compressed response.compress.bats
was removed. I merged the compressed test down into thebasic.bats
. The fluentbit and es deployment's happen in thesetup_file
function. Then 2 tests run quickly in sequence cutting a minute out of full runs.