Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

filter_log_to_metrics: Add documentation for add_label #1167

Merged
merged 3 commits into from
Oct 26, 2023
Merged

filter_log_to_metrics: Add documentation for add_label #1167

merged 3 commits into from
Oct 26, 2023

Conversation

wndhydrnt
Copy link
Contributor

@wndhydrnt wndhydrnt commented Jul 23, 2023 •
edited
Loading

@wndhydrnt wndhydrnt mentioned this pull request Jul 23, 2023
Merged
4 tasks
@wndhydrnt wndhydrnt changed the title filter_log_to_metrics: Add documentation for label filter_log_to_metrics: Add documentation for add_label Sep 24, 2023
@lecaros lecaros added waiting-for-user Waiting for user/contributors feedback or requested changes dco DCO failing labels Sep 24, 2023
@cosmo0920
Copy link
Contributor

Could you resolve DCO error on the commit 8074ff6?

cosmo0920
cosmo0920 requested changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@cosmo0920 cosmo0920 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding add_label parameter looks great. I found an invalid JSON parameter. Could you take a look then?

pipeline/filters/log_to_metrics.md Outdated Show resolved Hide resolved
@wndhydrnt wndhydrnt force-pushed the filter-log-to-metrics-label-key branch from 8074ff6 to 9552e6a Compare September 25, 2023 15:33
@wndhydrnt wndhydrnt requested a review from cosmo0920 September 25, 2023 15:35
@wndhydrnt
Copy link
Contributor Author

Hello @cosmo0920 @lecaros

Fluent Bit 2.10.0, which contains the add_label feature, has been released a few weeks ago already. This PR is still open so people have no way to discover through the documentation that the feature exists.

What is needed to get this PR merged?

@lecaros
Copy link
Contributor

lecaros commented Oct 26, 2023 •
edited
Loading

Hi @wndhydrnt,
Are we okay to include this doc without having fluent/fluent-bit#7967 merged yet?

edit: Just reviewed it, and I think we're ok. I'll merge it.

@lecaros lecaros merged commit d86e084 into fluent:master Oct 26, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cosmo0920 cosmo0920 cosmo0920 approved these changes

Assignees
No one assigned
Labels
dco DCO failing waiting-for-user Waiting for user/contributors feedback or requested changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wndhydrnt @cosmo0920 @lecaros