in_node_exporter_metrics: Add description for processes metrics #1184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
cosmo0920
force-pushed
the
cosmo0920-add-description-of-process-metrics-on-in_node_exporter_metrics
branch
from
1b9315e to
b296ae8
Compare
cosmo0920
changed the title
cosmo0920
force-pushed
the
cosmo0920-add-description-of-process-metrics-on-in_node_exporter_metrics
branch
2 times, most recently
from
7b9874e to
c292bcd
Compare
| @@ -33,6 +33,7 @@ This plugin is currently only supported on Linux based operating systems\ | |||
| | collector.loadavg.scrape\_interval | The rate in seconds at which loadavg metrics are collected from the host operating system. If a value greater than 0 is used then it overrides the global default otherwise the global default is used. | 0 seconds | | |||
| | collector.vmstat.scrape\_interval | The rate in seconds at which vmstat metrics are collected from the host operating system. If a value greater than 0 is used then it overrides the global default otherwise the global default is used. | 0 seconds | | |||
| | collector.filefd.scrape\_interval | The rate in seconds at which filefd metrics are collected from the host operating system. If a value greater than 0 is used then it overrides the global default otherwise the global default is used. | 0 seconds | | |||
| | collector.processes.scrape\_interval | The rate in seconds at which processes metrics are collected from the host operating system. If a value greater than 0 is used then it overrides the global default otherwise the global default is used. | 0 seconds | | |||
There was a problem hiding this comment.
I would use the singular process in these cases.
It might be good to explain what process metrics are available.
There was a problem hiding this comment.
It should be easily confusing but the official node_exporter and fluent-bit use processes as a metrics name actually....
There was a problem hiding this comment.
Yeah, sorry I meant in the description.
There was a problem hiding this comment.
Ohh, OK. This could be working as mentioning "system level of metrics".
There was a problem hiding this comment.
Fixed in 922a1fa.
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
@cosmo0920 can you resolve the conflicts? |
Signed-off-by: Hiroshi Hatake <[email protected]>
Signed-off-by: Hiroshi Hatake <[email protected]>
Signed-off-by: Hiroshi Hatake <[email protected]>
cosmo0920
force-pushed
the
cosmo0920-add-description-of-process-metrics-on-in_node_exporter_metrics
branch
from
922a1fa to
97bd6a1
Compare
|
I resolved conflicts on this PR. |
patrick-stephens
approved these changes
Jan 31, 2024
patrick-stephens
deleted the
cosmo0920-add-description-of-process-metrics-on-in_node_exporter_metrics
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.