Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hot-reloading: Add descriptions for Windows #1209

Merged
merged 4 commits into from
Oct 12, 2023

Conversation

cosmo0920
Copy link
Contributor

Corresponds to fluent/fluent-bit#7984.

cosmo0920 and others added 2 commits October 6, 2023 08:54
Co-authored-by: Pat <[email protected]>
Signed-off-by: Hiroshi Hatake <[email protected]>
@lecaros lecaros added conflict Waiting on conflict to be resolved by contributor backport to 2.1 PR's that need to be backported to branch 2.1 labels Oct 10, 2023
@cosmo0920
Copy link
Contributor Author

@lecaros The corresponding PR is only included in 2.2 dev branch. IMO, we needn't backport to 2.1 branch...

@lecaros
Copy link
Contributor

lecaros commented Oct 12, 2023

Understood @cosmo0920. I'll remove it from the backport list

@lecaros lecaros removed conflict Waiting on conflict to be resolved by contributor backport to 2.1 PR's that need to be backported to branch 2.1 labels Oct 12, 2023
@lecaros lecaros merged commit 315412f into master Oct 12, 2023
3 checks passed
@lecaros lecaros deleted the cosmo0920-hot-reloading-on-windows branch October 12, 2023 15:03
RicardoAAD pushed a commit to RicardoAAD/fluent-bit-docs that referenced this pull request Oct 12, 2023
* hot-reloading: Add descriptions for Windows

Signed-off-by: Hiroshi Hatake <[email protected]>

* Clarify the sentence meaning

Co-authored-by: Pat <[email protected]>
Signed-off-by: Hiroshi Hatake <[email protected]>

* hot-reload: Use quoted empty body

Signed-off-by: Hiroshi Hatake <[email protected]>

---------

Signed-off-by: Hiroshi Hatake <[email protected]>
Signed-off-by: Pat <[email protected]>
Co-authored-by: Pat <[email protected]>
Signed-off-by: RicardoAAD <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants