Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts: fix check for container version #1269

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

patrick-stephens
Copy link
Contributor

The 2.2.0 release of Fluent Bit failed to update the container image version: #1252

https://github.com/fluent/fluent-bit/actions/runs/6810802273/job/18519927519#step:6:22

+ MAJOR_VERSION=2.2
+ grep -q 2.2.0 /home/runner/work/fluent-bit/fluent-bit/installation/docker.md
+ echo 'Found 2.2.0 already in the Docker docs so skipping update'
Found 2.2.0 already in the Docker docs so skipping update

This was resolved in #1268.

The reason for the failure is grep using the value passed as a regex rather than a fixed literal string:

$ grep -F "2.2.0" installation/docker.md
| 2.2.0-debug | x86_64, arm64v8, arm32v7 | Debug images |
| 2.2.0 | x86_64, arm64v8, arm32v7 | Release [v2.2.0](https://fluentbit.io/announcements/v2.2.0/) |
$ grep "2.2.0" installation/docker.md
| 2.2.0-debug | x86_64, arm64v8, arm32v7 | Debug images |
| 2.2.0 | x86_64, arm64v8, arm32v7 | Release [v2.2.0](https://fluentbit.io/announcements/v2.2.0/) |
[{"critical":{"identity":{"docker-reference":"index.docker.io/fluent/fluent-bit"},"image":{"docker-manifest-digest":"sha256:c740f90b07f42823d4ecf4d5e168f32ffb4b8bcd87bc41df8f5e3d14e8272903"},"type":"cosign container image signature"},"optional":{"release":"2.0.6","repo":"fluent/fluent-bit","workflow":"Release from staging"}}]

Notice in the second one we match the string 27290 as this is the 2.2.0 regex.

@patrick-stephens patrick-stephens merged commit c91dcc1 into master Dec 7, 2023
3 checks passed
@patrick-stephens patrick-stephens deleted the fixup_update_versions_dec7 branch December 7, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant