nat output module doc update #1416
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnorris-cs
reviewed
Jul 30, 2024
cnorris-cs
reviewed
Jul 30, 2024
cnorris-cs
approved these changes
Jul 30, 2024
Co-authored-by: Craig Norris <[email protected]> Signed-off-by: randomizedcoder <[email protected]>
Co-authored-by: Craig Norris <[email protected]> Signed-off-by: randomizedcoder <[email protected]>
|
Awesome. Thanks mate! |
|
Can you sort the DCO check @randomizedcoder as it's a hard block on merging otherwise? |
pwhelan
approved these changes
Aug 1, 2024
There was a problem hiding this comment.
LGTM.
I checked the code and in fact we are only outputting JSON to NATS. If we want to stream msgpack an issue should be opened for that. Please rewrite your commit to be signed off, please.
lecaros
added
waiting-for-user
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small update to the nats output module documentation