New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup for about fluentbit and fluentd #1455

Merged

esmerel merged 3 commits into master from lynettemiles/sc-105688/update-about-fluentd-and-fluent-bit-md-fluent

Sep 11, 2024

Contributor

esmerel commented Sep 10, 2024

Standardizing this page for style.

Note: Line 36 was confusing to me. I rewrote it to something that makes sense, but I'm also not completely sure I'm correct.


          Cleanup for about fluentbit and fluentd

b18d97b

Signed-off-by: Lynette Miles <[email protected]>

esmerel requested review from a team as code owners

September 10, 2024 23:28

cnorris-cs reviewed

View reviewed changes

about/fluentd-and-fluent-bit.md Outdated Show resolved Hide resolved

cnorris-cs reviewed

View reviewed changes

about/fluentd-and-fluent-bit.md Outdated Show resolved Hide resolved

cnorris-cs reviewed

View reviewed changes

about/fluentd-and-fluent-bit.md Outdated Show resolved Hide resolved

cnorris-cs reviewed

View reviewed changes

about/fluentd-and-fluent-bit.md Outdated Show resolved Hide resolved

cnorris-cs reviewed

View reviewed changes

about/fluentd-and-fluent-bit.md Outdated Show resolved Hide resolved

cnorris-cs reviewed

View reviewed changes

about/fluentd-and-fluent-bit.md Outdated Show resolved Hide resolved

cnorris-cs reviewed

View reviewed changes

about/fluentd-and-fluent-bit.md Outdated Show resolved Hide resolved

cnorris-cs reviewed

View reviewed changes

about/fluentd-and-fluent-bit.md Outdated Show resolved Hide resolved

cnorris-cs approved these changes

View reviewed changes

Contributor

cnorris-cs left a comment

I left suggestions, but I've added my approval based on that to keep this moving.

(And, yes, I know I made some additional changes. This is just the first page we've updated like this. I'll be able to focus more on just the basic changes as we go.)

esmerel and others added 2 commits

September 11, 2024 09:19


          Apply suggestions from code review

3f5830e

Co-authored-by: Craig Norris <[email protected]>
Signed-off-by: esmerel <[email protected]>


          Update fluentd-and-fluent-bit.md

a8cb31a

Signed-off-by: esmerel <[email protected]>

esmerel merged commit b83439e into master

5 checks passed

esmerel deleted the lynettemiles/sc-105688/update-about-fluentd-and-fluent-bit-md-fluent branch

September 11, 2024 16:32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet