Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fluent bit: docs: Updating validating data for style #1457

Conversation

esmerel
Copy link
Contributor

@esmerel esmerel commented Sep 12, 2024

No description provided.

@esmerel esmerel requested review from a team as code owners September 12, 2024 15:25
Signed-off-by: Lynette Miles <[email protected]>
Expect filter sets rules that aims to validate certain criteria like:
Add data validation between each step to ensure your data structure is correct.

This example uses the `expect` filter.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really don't know on this one, and it may be out of scope of these changes. Is it Expect or expect? I've seen both capitalizations in this doc.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to use caps at the beginning of sentences, but lowercase everywhere else. because my brain objected to lowercase at the beginning of sentences.

Copy link
Contributor

@cnorris-cs cnorris-cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a comment, but I've added my approval based on that to keep this moving.

@esmerel esmerel merged commit 59b0598 into master Sep 12, 2024
5 checks passed
@esmerel esmerel deleted the lynettemiles/sc-108080/update-local-testing-validating-your-data branch September 12, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants