Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fluent docs: regex: Updating regex doc for style and clarity #1465

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Fluent docs: regex: Updating regex doc for style and clarity #1465

merged 2 commits into from
Sep 20, 2024

Conversation

esmerel
Copy link
Contributor

@esmerel esmerel commented Sep 19, 2024

No description provided.

@esmerel esmerel requested review from a team as code owners September 19, 2024 17:29
cnorris-cs
cnorris-cs approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@cnorris-cs cnorris-cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left suggestions, but I've added my approval based on that to keep this moving.

@esmerel @cnorris-cs
Apply suggestions from code review
6410511 
Co-authored-by: Craig Norris <[email protected]>
Signed-off-by: esmerel <[email protected]>
@esmerel esmerel merged commit 0f11c48 into master Sep 20, 2024
5 checks passed
@esmerel esmerel deleted the lynettemiles/sc-108482/update-pipeline-parsers-regular-expression branch September 20, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cnorris-cs cnorris-cs cnorris-cs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@esmerel @cnorris-cs