pipeline: inputs: docker-metrics: add container path config #1516
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
documentation
What does this PR do / Why do we need it?:
At times the user might need to have their docker Daemon data directory setup somewhere else other than the default path. Currently the Docker Log Based Metrics plugin does not pick it up automatically and has it hard coded here.
We can simply pass
path.containers
to the config and that will do the trick as the plugin code is also looking at that same config hereThis can significantly save the end user research time and also opens their eyes to the capability of the docker metrics plugin
Testing done on this change:
This was tested, let's assume my docker
data-root
is set to/some-path/docker
the bellow config worked, and the plugin was able to access the containers as expected using this configI have also tried adding
DEFAULT_CONTAINERS_PATH
to/etc/sysconfig/fluent-bit
as per this document, but that did not work.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.