out_loki: make it clear setting labels removes the keys from record #1536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
Thanks for the contribution but please resolve the DCO requirements - we cannot merge without it unfortunately. |
Related to the pull request fluent/fluent-bit#9766 The documentation doesn't make it clear, but the code seems to be trying to work this way. Also minor typo fix. Signed-off-by: jantti <[email protected]>
eschabell
added
waiting-for-user
|
@ajantti I've nudged the code PR fluent/fluent-bit#9766 for review to get that moved forward, once that is merged, this docs PR could merge if you could please fix the current conflicts? |
|
@esmerel another one to review and not merge please, just need the review! |
esmerel
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to the pull request fluent/fluent-bit#9766 The documentation doesn't make it clear, but the code seems to be trying to work this way.
Also minor typo fix.