Skip to content

Conversation

cosmo0920
Copy link
Contributor

This is subsequent PR of #1471.

Also I added the reason why we need to support these parameters and how
to use them.

@cosmo0920 cosmo0920 requested review from a team as code owners July 7, 2025 08:11
@cosmo0920 cosmo0920 force-pushed the cosmo0920-encoding-parameter-on-in_tail branch from d8ef3d9 to 331b498 Compare July 7, 2025 08:25
@lecaros
Copy link
Contributor

lecaros commented Jul 7, 2025

@fluent/chronosphere-tech-writers could you please review this one? Thanks in advance!

Copy link
Member

@alexakreizinger alexakreizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggested some changes for style, but adding my approval based on those 😁 happy to take another look if you need to make changes to any of my changes, too. (also I want to make sure any changes stay in sync with #1471!)

@cosmo0920 cosmo0920 force-pushed the cosmo0920-encoding-parameter-on-in_tail branch 2 times, most recently from e206b78 to 2b5890b Compare July 8, 2025 03:13
@eschabell eschabell added the conflict Waiting on conflict to be resolved by contributor label Oct 20, 2025
@eschabell eschabell self-assigned this Oct 21, 2025
@eschabell eschabell added the waiting-for-user Waiting for user/contributors feedback or requested changes label Oct 21, 2025
@eschabell
Copy link
Collaborator

@cosmo0920 if you can resolve the conflicts, I can get this merged together with #1471

cosmo0920 and others added 3 commits October 22, 2025 16:43
Co-authored-by: Alexa Kreizinger <[email protected]>
Signed-off-by: Hiroshi Hatake <[email protected]>
Also I added the reason why we need to support these parameters and how
to use them.

Signed-off-by: Hiroshi Hatake <[email protected]>
@cosmo0920 cosmo0920 force-pushed the cosmo0920-encoding-parameter-on-in_tail branch from 2b5890b to e54556f Compare October 22, 2025 07:58
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

markdownlint

[markdownlint] reported by reviewdog 🐶
MD004/ul-style Unordered list style [Expected: dash; Actual: asterisk]

* `Win874` (Thai): (Alias: `CP874`)

Signed-off-by: Hiroshi Hatake <[email protected]>
@cosmo0920 cosmo0920 force-pushed the cosmo0920-encoding-parameter-on-in_tail branch from a699d44 to 37e837d Compare October 22, 2025 08:05
@eschabell
Copy link
Collaborator

@cosmo0920 this is still in conflict... did get #1471 merged this morning my time, can you revisit?

@eschabell eschabell removed waiting-for-user Waiting for user/contributors feedback or requested changes conflict Waiting on conflict to be resolved by contributor labels Oct 22, 2025
@eschabell
Copy link
Collaborator

eschabell commented Oct 22, 2025

@esmerel good morning! The only thing holding back merging this PR are a couple of Vale checks showing the following errors:

Raw Output:
{"message": "[FluentBit.Contractions] Feel free to use 'aren't' instead of 'are not'.", "location": {"path": "pipeline/inputs/tail.md", "range": {"start": {"line": 484, "column": 59}}}, "severity": "INFO"}
Error: [vale] reported by reviewdog 🐶
[FluentBit.Latin] Use 'for example' instead of 'e.g.,'.

Raw Output:
{"message": "[FluentBit.Units] Put a nonbreaking space between the number and the unit in '16B'.", "location": {"path": "pipeline/inputs/tail.md", "range": {"start": {"line": 502, "column": 9}}}, "severity": "INFO"}
Error: reviewdog: Too many results (annotations) in diff.
You may miss some annotations due to GitHub limitation for annotation created by logging command.
Please check GitHub Actions log console to see all results.

Can you take a look at this?

@eschabell eschabell added the waiting-on-review Waiting on a review from mainteners label Oct 22, 2025
@eschabell eschabell requested a review from esmerel October 22, 2025 12:43
@eschabell eschabell added the dco DCO failing label Oct 22, 2025
This should correct the severe vale errors and most of the suggestions, as well as matching current style.

Signed-off-by: Lynette  Miles <[email protected]>

- Legacy Windows systems with applications that use traditional code pages (for example, ShiftJIS, GBK, Win1252).

### Configuration parameters

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[markdownlint] reported by reviewdog 🐶
MD024/no-duplicate-heading Multiple headings with the same content [Context: "### Configuration parameters"]

@esmerel
Copy link
Contributor

esmerel commented Oct 22, 2025

@esmerel good morning! The only thing holding back merging this PR are a couple of Vale checks showing the following errors:

Can you take a look at this?

Done! Don't worry about copying the errors out, I can see them in the web interface. If I get pinged I will try to fix them as I get time. =)

@eschabell eschabell removed the dco DCO failing label Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-on-review Waiting on a review from mainteners

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants