pipeline: outputs: datadog: added documentation for site configuration field #2032
+5
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lucas Tembras <[email protected]>
lucastemb
force-pushed
the
lucastemb/site_configuration_field
branch
from
64bf6ba to
ec88270
Compare
Signed-off-by: Lucas Tembras <[email protected]>
Signed-off-by: Lucas Tembras <[email protected]>
3 tasks
alexakreizinger
approved these changes
Aug 1, 2025
There was a problem hiding this comment.
thanks for submitting a PR @lucastemb 😁 I made one small suggestion to match the phrasing we've used in other pages, but otherwise LGTM!
one question, though: is the feature itself still unmerged? if so, you can add the waiting-on-code-merge label to this docs PR to make sure none of us merge it prematurely.
Co-authored-by: Alexa Kreizinger <[email protected]> Signed-off-by: Lucas Tembras <[email protected]>
|
@alexakreizinger Yup, still waiting for approval on the feature, but I don't believe I have the option to add the label myself. 😢 |
|
I executed CI workflows and added a suggested label. Thanks for your work! 👍 |
hestonhoffman
approved these changes
Aug 1, 2025
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added supporting documentation for the following PR that seeks to add support for a
siteconfiguration field to give customers options on where to send telemetry data.