-
Notifications
You must be signed in to change notification settings - Fork 1.7k
ci, dockefile: frozen version of CMake #10178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
64da6ba
to
69861bd
Compare
4 tasks
e0c2ef0
to
c6dd996
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably need to fix up the docker files as well.
Thanks for this, can you link it to the relevant issue too?
Cc @edsiper
ea86803
to
c0fb213
Compare
c0fb213
to
4c1b61d
Compare
b7d2a46
to
c294e1a
Compare
…nners due to deprecation of Ubuntu 20.04 runners (actions/runner-images#11101). Signed-off-by: Marat Abrarov <[email protected]>
…CMake projects not compatible with CMake 4.0 (actions/runner-images#11926). Signed-off-by: Marat Abrarov <[email protected]>
…ne for unit tests on s390x and riscv64. Signed-off-by: Marat Abrarov <[email protected]>
…to ensure no build issue due to incompatibility with new CMake versions. Signed-off-by: Marat Abrarov <[email protected]>
…ported one for Linux containers. Signed-off-by: Marat Abrarov <[email protected]>
Signed-off-by: Marat Abrarov <[email protected]>
c294e1a
to
71cc8bc
Compare
thank you! |
This was referenced Apr 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes (excluding #10230):
This PR fixes #10157 for CI and Dockerfiles.
Solution used:
Tested CI changes on #7608 (cherry-picked this PR commits and #10180 commits on top of #7608).
It looks like jwlawson/actions-setup-cmake GitHub action doesn't support Linux aarch64 yet - refer to jwlawson/actions-setup-cmake#74 - so for GitHub Linux aarch64 builds (until jwlawson/actions-setup-cmake#74 is completed and released) this PR downloads and uses official CMake build from https://github.com/Kitware/CMake/releases. Unfortunately, the same solution cannot be applied to s390x and riscv64 CI builds and to images for Linux containers due to not all platforms required for these cases are represented among official CMake builds, so for:
this PR just ensures that version of CMake (installed from Ubuntu repository) is not greater than the latest supported (is < 4.0).
See also CMAKE_POLICY_VERSION_MINIMUM (CMake 4+ only).
Please note that building of Windows Containers images in this PR fails because of #10158, i.e. it is existing (in master branch) issue. Refer to #10180 for the fix which is based on (includes) this PR.
Update: version of CMake was downgraded in Ubuntu GitHub actions runners - refer to actions/runner-images#11933 - which means that the issue this pull request (#10178) fixes should be already fixed since 4/12/2025. IMHO, this pull request providing explicit and configurable version of CMake is still helpful. It also makes possible to test different versions of CMake if needed.
Update: since 04/20/2025 this pull request is based on #10230, because otherwise this pull request fails to build.
Testing
Only x86_64 builds (refer to modified packaging/build-config.json) were tested using packaging/local-build-all.sh script. Log of script is available at flb_packaging_local-build-all.log.
ok-package-test
label to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.