dockerfile: Enable default SIMD support in Docker (#10215) #10225
+12
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinyongchoi
requested review from
niedbalski,
patrick-stephens and
celalettin1286
as code owners
jinyongchoi
force-pushed
the
10215-enable_simd_in_container
branch
from
d3103fb to
12620cb
Compare
According to the documentation, SIMD is supposed to be enabled by default in Fluent Bit container images. This commit updates the Dockerfile to reflect that, enabling SIMD by default. Signed-off-by: jinyong.choi <[email protected]>
jinyongchoi
force-pushed
the
10215-enable_simd_in_container
branch
from
12620cb to
06d8967
Compare
|
I think it makes sense to wait until this ticket(#10178) is completed before proceeding. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the documentation,
SIMD is supposed to be enabled by default in Fluent Bit container images.
This commit updates the Dockerfile to reflect that, enabling SIMD by default.
Closes #10215
Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.