-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
out_pgsql: pass connection options to postgresql client #6837
Conversation
Example Configuration
Terminal Output
Valgrind Output
DocumentationThe PR is available. Back CompatibilityThe plugin pass NULL value by default. So, it will not affect future versions. |
@bkayranci hi! thanks for this! can you add the missing documentation for this? |
I attached the valgrind output to above comment. Is there any checks for approving? |
I wonder if the commit checker regex is failing due to non Ascii characters in your sign off. It looks fine to me and using your actual name should be acceptable. Edit: debug logging shows it is getting the old commit message still Double check your commit and force push a new one to verify @bkayranci |
Actually, it seems on Commits Tab. When I tried to force push, I got "Everything up-to-date". I will push a dummy commit. |
Signed-off-by: Turkalp Burak Kayrancioglu <[email protected]>
libpq supports connection options on the postgresql plugin. Passing connection options to client are basic functionality but the plugin cannot pass connection options. I patched it.
#6836
Enter
[N/A]
in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-test
label to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.