in_forward: Handle multiply concatenated gzip payloads #8665
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On out_forward in Fluentd payloads, sometimes gzip compressed payloads are concatenated because Fluentd has a capability to compress its buffers with gzip compression.
With this circumstance, Fluentd sometimes concatenates its payloads on forward protocol.
This causes that Fluent Bit gives up to uncompress for the concatenated ones.
In this PR, I implemented for decoding way to distinguish whether the ingested forwarded payloads is concatenated or not.
This is not mandatory specification and not well-documented behavior on Ruby's zlib gem.
But, in fact, Fluentd is heavily relying on this behavior for saving the CPU usage to avoid unnecessary compressions/decompressions.
This is why I found that the reason Fluentd is actually relying on the concatenated gzipped payloads:
https://github.com/fluent/fluentd/blob/master/lib/fluent/plugin/compressable.rb#L57-L93
Enter
[N/A]
in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-test
label to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.