-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws: add support for EKS Pod Identities #9206
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Wesley Pettit <[email protected]>
This change brings the http credential provider in line with the latest spec and adds support for: - EKS Pod Identity - validate/support EKS credential link local IP 169.254.170.23 - Latest HTTP Provider spec: - AWS_CONTAINER_CREDENTIALS_RELATIVE_URI - AWS_CONTAINER_CREDENTIALS_FULL_URI - AWS_CONTAINER_AUTHORIZATION_TOKEN - AWS_CONTAINER_AUTHORIZATION_TOKEN_FILE Signed-off-by: Wesley Pettit <[email protected]>
Signed-off-by: Wesley Pettit <[email protected]>
@edsiper I tested these changes thoroughly on a new EKS cluster back in May. My change has unit tests which pass. It should be safe to merge after I just now performed a simple rebase with no conflicts. Unfortunately I am unable test this again right now. Please see my comments on the alternate (mostly the same) implementation: #9013 (review) |
@PettitWesley there are some memory leaks detected in the unit test: https://github.com/fluent/fluent-bit/actions/runs/10381178881/job/28776004954?pr=9206#step:5:3421 |
In the branch eks-pod-identity3.0 I pushed some commits on top of this branch/PR to fix the leaks found. The patch in order are:
Remaining issues found with Valgrind:
just trying to speed up things, can you pls review the commits and cherry-pick them ? |
moving this for 3.2. we need someone to incorporate the changes |
Enter
[N/A]
in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-test
label to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.