build: Use signed char in RISC-V 64bit #9524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cosmo0920
force-pushed
the
cosmo0920-riscv64-signed-char
branch
2 times, most recently
from
d40fca6 to
ec674fa
Compare
cosmo0920
force-pushed
the
cosmo0920-riscv64-signed-char
branch
from
ec674fa to
824f9fa
Compare
Signed-off-by: Hiroshi Hatake <[email protected]>
Signed-off-by: Hiroshi Hatake <[email protected]>
This is because this workflow is not injected and used clang packages Signed-off-by: Hiroshi Hatake <[email protected]>
Signed-off-by: Hiroshi Hatake <[email protected]>
…erations on riscv64 Signed-off-by: Hiroshi Hatake <[email protected]>
cosmo0920
force-pushed
the
cosmo0920-riscv64-signed-char
branch
from
824f9fa to
5a5ac76
Compare
cosmo0920
requested review from
niedbalski,
patrick-stephens,
celalettin1286 and
fujimotos
as code owners
|
In this PR changes, now we reached green CI result for s390x CI task. |
patrick-stephens
approved these changes
Dec 6, 2024
Signed-off-by: Hiroshi Hatake <[email protected]>
patrick-stephens
approved these changes
Dec 11, 2024
patrick-stephens
pushed a commit
that referenced
this pull request
Dec 19, 2024
* build: riscv64: Add a fundamental architecture cmake file for riscv64 Signed-off-by: Hiroshi Hatake <[email protected]> * build: Add riscv64 architecture target for internal tests Signed-off-by: Hiroshi Hatake <[email protected]> * build: Restrict to use gcc only This is because this workflow is not injected and used clang packages Signed-off-by: Hiroshi Hatake <[email protected]> * build: Use gcc-9 and g++-9 on qemu workflow Signed-off-by: Hiroshi Hatake <[email protected]> * build: Use ubuntu-22.04 distro due to try to use gcc-12 for atomic operations on riscv64 Signed-off-by: Hiroshi Hatake <[email protected]> * build: riscv64: Remove commented out lines Signed-off-by: Hiroshi Hatake <[email protected]> --------- Signed-off-by: Hiroshi Hatake <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as other platforms, we have to use signed char even if RISC-V 64bit(riscv64).
For testing on RISCV64, we can also use uraimo/run-on-arch-action action to set up with riscv64 emulator with qemu.
In my visionfive RISC-V 64bit board, I succeeded to pass signedness sensitive tests which are flb-it-pack and flb-it-utils.
This is also causing problems on AArch64 Linux.
And there is also occurring on RISCV64 Linux.
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.