Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin_proxy: Allow to execute flush callback on Golang side during hot-reloading #9734

Merged
merged 1 commit into from
Dec 19, 2024
Merged

plugin_proxy: Allow to execute flush callback on Golang side during hot-reloading #9734

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions src/flb_plugin_proxy.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,15 +50,6 @@ static void proxy_cb_flush(struct flb_event_chunk *event_chunk,
(void) i_ins;
(void) config;

/* To prevent flush callback executions, we need to check the
* status of hot-reloading. The actual problem is: we don't have
* pause procedure/mechanism for output plugin. For now, we just halt the
* flush callback here during hot-reloading is in progress. */
if (config->shutdown_by_hot_reloading == FLB_TRUE) {
flb_trace("[GO] hot-reloading is in progress. Retry flushing");
FLB_OUTPUT_RETURN(FLB_RETRY);
}

cosmo0920 marked this conversation as resolved.
Show resolved Hide resolved
#ifdef FLB_HAVE_PROXY_GO
if (ctx->proxy->def->proxy == FLB_PROXY_GOLANG) {
flb_trace("[GO] entering go_flush()");
Expand Down
Loading