-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
in_systemd: tests: Provide restoring way the previous behavior #9764
base: master
Are you sure you want to change the base?
Conversation
e35f861
to
802392a
Compare
Signed-off-by: Hiroshi Hatake <[email protected]>
802392a
to
3ced629
Compare
@cosmo0920 are we sure is not a memory leak ? I ask since the user reported excessive memory usage: https://fluent-all.slack.com/archives/C0CTQGHKJ/p1734955974377129 |
Yeah, there is a possibility to be existing some of the memory leaks. But surely we increased memory usages in this plugin with using the mediate representation via cfl kvlist. |
The revised behavior needs more memory than just serializing one-by-one way.
So, for the lower memory environments or resource capped containers, we need to provide a restoring way with previous behavior.
With the previous behavior, the last element on the duplicated key is only effective when encoding as JSON.
Enter
[N/A]
in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-test
label to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.