Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in_systemd: tests: Provide restoring way the previous behavior #9764

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cosmo0920
Copy link
Contributor

@cosmo0920 cosmo0920 commented Dec 24, 2024

The revised behavior needs more memory than just serializing one-by-one way.
So, for the lower memory environments or resource capped containers, we need to provide a restoring way with previous behavior.
With the previous behavior, the last element on the duplicated key is only effective when encoding as JSON.


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • Run local packaging test showing all targets (including any new ones) build.
  • Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

@cosmo0920 cosmo0920 force-pushed the cosmo0920-provide-restoring-behavior-way branch from e35f861 to 802392a Compare December 24, 2024 09:37
@cosmo0920 cosmo0920 changed the title in_systemd: tests: Provide restoring way the previuous behavior in_systemd: tests: Provide restoring way the previous behavior Dec 24, 2024
@cosmo0920 cosmo0920 changed the title in_systemd: tests: Provide restoring way the previous behavior in_systemd: tests: Provide restoring way to the previous behavior Dec 24, 2024
@cosmo0920 cosmo0920 force-pushed the cosmo0920-provide-restoring-behavior-way branch from 802392a to 3ced629 Compare December 24, 2024 09:46
@cosmo0920 cosmo0920 changed the title in_systemd: tests: Provide restoring way to the previous behavior in_systemd: tests: Provide restoring way the previous behavior Dec 24, 2024
@edsiper
Copy link
Member

edsiper commented Dec 24, 2024

@cosmo0920 are we sure is not a memory leak ? I ask since the user reported excessive memory usage:

https://fluent-all.slack.com/archives/C0CTQGHKJ/p1734955974377129

@cosmo0920
Copy link
Contributor Author

@cosmo0920 are we sure is not a memory leak ? I ask since the user reported excessive memory usage:

https://fluent-all.slack.com/archives/C0CTQGHKJ/p1734955974377129

Yeah, there is a possibility to be existing some of the memory leaks. But surely we increased memory usages in this plugin with using the mediate representation via cfl kvlist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants