out_kafka2: Broker pool to take care of fetching metadata #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dipendra-singh
force-pushed
the
add_target_topics
branch
from
bd04185 to
cd4df53
Compare
|
@ashie Requesting review here |
|
This PR has been automatically marked as stale because it has been open 90 days with no activity. Remove stale label or comment or this PR will be closed in 30 days |
Signed-off-by: Dipendra Singh <[email protected]>
kenhys
force-pushed
the
add_target_topics
branch
from
cd4df53 to
b0f3a10
Compare
|
LGTM. |
|
Thanks @dipendra-singh ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
#502
What this PR does / why we need it:
On enabling the get_kafka_client_log true, this can be figured out the leader of partitions is being queried multiple times: here
this metadata if refreshed by broker pool (here). Adding this in producer would resolve the issue.
additionally, this is a part of an optimisation done on ruby-kafka.
Test cases passing post the changes.
Docs Changes:
NA