Bump required ruby version #4745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI: related PR. |
kenhys
force-pushed
the
bump-ruby-version
branch
3 times, most recently
from
ed5ebca to
c9a96f6
Compare
|
Can you update the version in README ? Line 33 in 26812c8 |
Even though it still actually work with older version of ruby, it might be better recommending supported Ruby version. * Ruby 2.7 EOL: 2023-03-31 * Ruby 3.0 EOL: 2024-04-23 * Ruby 3.1 EOL: 2025-03-31 Signed-off-by: Kentaro Hayashi <[email protected]>
kenhys
force-pushed
the
bump-ruby-version
branch
from
c9a96f6 to
ba5b32f
Compare
|
Thanks, I've fixed it. |
daipom
pushed a commit
that referenced
this pull request
Jan 16, 2025
**Which issue(s) this PR fixes**: Fixes # **What this PR does / why we need it**: Async v2.0 just supports Ruby 3.1 or above. When we had been supporting Ruby 2.7 and 3.0, we need async v1.x and v2.x both. Related to #4619 Next fluentd version will drop support of Ruby 3.1 or below. So, now we can remove the codes for async v1.x Ref. #4745 **Docs Changes**: **Release Note**: Signed-off-by: Shizuo Fujita <[email protected]>
daipom
pushed a commit
that referenced
this pull request
Jan 16, 2025
**Which issue(s) this PR fixes**: Fixes # **What this PR does / why we need it**: Next fluentd version will drop support of Ruby 3.1 or below. Ref. #4745 So, we can remove the workaround for Ruby 2.7 and 3.0 on macOS that added at #3579 **Docs Changes**: **Release Note**: Signed-off-by: Shizuo Fujita <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Fixes #
What this PR does / why we need it:
Raise baseline version of Ruby to 3.2.
fluent-package v5 (LTS) adopts ruby 3.2, so it is reasonable to set minimum version to Ruby 3.2.
NOTE: these kind of changes might be better to apply in v1.19.0
Docs Changes:
https://docs.fluentd.org/quickstart/faq
fluent/fluentd-docs-gitbook#524
Release Note:
N/A