Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in_tail: reduce the lifespan of the buffer area #4763

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

Watson1978
Copy link
Contributor

@Watson1978 Watson1978 commented Jan 9, 2025

Which issue(s) this PR fixes:
Fixes #

What this PR does / why we need it:
When log files are rotated at high speed, the lifespan of IOHandler objects may become extended.
Along with this, the lifespan of @iobuf also increases.

Since @iobuf uses 8 KB of memory, if many such objects exist simultaneously, memory usage might significantly increase.

Docs Changes:

Release Note:

@Watson1978 Watson1978 changed the title in_tail: reduce the survival time of the buffer area in_tail: reduce the lifespan of the buffer area Jan 9, 2025
@Watson1978 Watson1978 marked this pull request as ready for review January 9, 2025 05:32
@Watson1978 Watson1978 requested a review from daipom January 9, 2025 05:36
@daipom daipom added this to the v1.19.0 milestone Jan 9, 2025
Copy link
Contributor

@daipom daipom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@daipom daipom merged commit 17d9322 into fluent:master Jan 9, 2025
13 checks passed
@Watson1978 Watson1978 deleted the iobuf branch January 10, 2025 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants