Skip to content

out_forward: add warning for zstd as experimental #4896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

daipom
Copy link
Contributor

@daipom daipom commented Apr 9, 2025

Which issue(s) this PR fixes:

What this PR does / why we need it:
When using compress zstd for out_forward, output the following warning log.

zstd compression feature is an experimental new feature supported since v1.19.0.
Please make sure that the destination server also supports this feature before using it.
in_forward plugin for Fluentd supports it since v1.19.0.

In #4758, it was agreed that we would refrain from updating the forward protocol v1.5 for the time being and instead output a log message indicating that this feature is experimental.

for now, we will make zstd available as an exprimenatal feature on the Fluentd side, and note in the documentation that it is an experimental feature that cannot be used unless the server supports it.

Just displaying as a warning log to tell: "This is experimental feature and not standardized yet" or similar message should be enough.

Docs Changes:
Not needed. (It should be done as #4657)

Release Note:
Not needed. (A note for #4657 would be enough.)

@daipom daipom added this to the v1.19.0 milestone Apr 9, 2025
@daipom daipom moved this to Work-In-Progress in Fluentd Kanban Apr 9, 2025
Copy link
Contributor

@kenhys kenhys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kenhys kenhys merged commit 3a6826a into fluent:master Apr 10, 2025
10 checks passed
@daipom daipom deleted the out_forward-add-warning-for-zstd-as-experimental branch April 10, 2025 01:46
@daipom
Copy link
Contributor Author

daipom commented Apr 10, 2025

Thanks for your review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants