[fluentd] Add Ingress.

[pecastro]

Add Ingress resource to fluentd for Deployment/StatefulSet options.

[dioguerra]

This should be ok. Do you mind rebasing?

[pecastro]

@dioguerra Done.

[dioguerra]

Can you please fix the extraHostnames? it's breaking stuff

Also, can you ident to align the arrays with the objects?

spec:
  {{- if .Values.ingress.tls }}
  tls:
  {{- range .Values.ingress.tls }}
  - hosts:
    {{- range .hosts }}
    - {{ . | quote }}
    {{- end }}
    {{- with .secretName }}
    secretName: {{ . }}
    {{- end }}
  {{- end }}
  {{- end }}
  rules:
  {{- range concat .Values.ingress.hosts }}
  - host: {{ .host | quote }}
    http:
      paths:
      - path: /
        pathType: Prefix
        backend:
          service:
            name: {{ $fullName }}
            port:
              {{- if .port }}
              number: {{ .port }}
              {{- end }}
  {{- end }}

[dioguerra]

@pecastro ping

[pecastro]

Pushed a correction.

helm lint .
==> Linting .

1 chart(s) linted, 0 chart(s) failed
pecastro@localhost /download/fluent-helm-charts/charts/fluentd[fluentd-add-ingress]$ helm template fluentd ../fluentd/ -n kube-system -s templates/ingress.yaml  --set ingress.enabled=true
---
# Source: fluentd/templates/ingress.yaml
apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
  name: fluentd
  labels:
    helm.sh/chart: fluentd-0.4.4
    app.kubernetes.io/name: fluentd
    app.kubernetes.io/instance: fluentd
    app.kubernetes.io/version: "v1.15.2"
    app.kubernetes.io/managed-by: Helm
spec:
  rules:
    - host: "[]"
      http:
        paths:
          - path: /
            pathType: Prefix
            backend:
              service:
                name: fluentd
                port:

[pecastro]

@dioguerra pong.

[amontalban]

Would be great to have this in the official Helm Chart, in our case we are creating it manually.

@dioguerra what do we need to make it happen?

[dioguerra]

Hello. Check the TODO for the merge:

• Verify all issues above are solved
• Update the Chart.yaml helm version

Not mandatory:

• Ingress can be defined without a specific host, make this work?. Also set a default port?

@amontalban @pecastro - thanks for pinging :D

[dioguerra]

LGTM, thnaks

[dioguerra]

Please fix issues as found by the CI. @pecastro

[dioguerra]

Hey @pecastro.

Thank you for your contribution! Would you also be interested to fix the tests?
#440

Cheers,

[pecastro]

I'll have a looksie ...

[discostur]

May you also add the ingressClass option? Would be really nice ...