-
-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add style keys for some ribbon controls #1178
feat: add style keys for some ribbon controls #1178
Conversation
| Old | New | |-----------------------------------------------|-----------------------------------------------| | --- | Fluent.Ribbon.Styles.ApplicationMenu | | Fluent.Ribbon.Templates.ApplicationMenuButton | Fluent.Ribbon.Templates.ApplicationMenu | | --- | Fluent.Ribbon.Styles.ColorGallery | | Fluent.Ribbon.Styles.RibbonComboButton | Fluent.Ribbon.Styles.ComboBox.ToggleButton | | --- | Fluent.Ribbon.Styles.ComboBox | | Fluent.Ribbon.Templates.RibbonComboButton | Fluent.Ribbon.Templates.ComboBox.ToggleButton | | Fluent.Ribbon.Templates.RibbonCombobox | Fluent.Ribbon.Templates.ComboBox | | --- | Fluent.Ribbon.Styles.RibbonMenu | | --- | Fluent.Ribbon.Styles.TextBox | | --- | Fluent.Ribbon.Styles.ScrollBar | | --- | Fluent.Ribbon.Styles.StatusBarMenuItem | | --- | Fluent.Ribbon.Styles.WindowCommands |
In the last commit, there were some omissions in the addition of the style key. Add the following three keys. - Fluent.Ribbon.Styles.InRibbonGallery - Fluent.Ribbon.Styles.RadioButton - Fluent.Ribbon.Styles.StatusBar | Old | New | |-----------------------------------------------|-----------------------------------------------| | --- | Fluent.Ribbon.Styles.ApplicationMenu | | Fluent.Ribbon.Templates.ApplicationMenuButton | Fluent.Ribbon.Templates.ApplicationMenu | | --- | Fluent.Ribbon.Styles.ColorGallery | | Fluent.Ribbon.Styles.RibbonComboButton | Fluent.Ribbon.Styles.ComboBox.ToggleButton | | --- | Fluent.Ribbon.Styles.ComboBox | | Fluent.Ribbon.Templates.RibbonComboButton | Fluent.Ribbon.Templates.ComboBox.ToggleButton | | Fluent.Ribbon.Templates.RibbonCombobox | Fluent.Ribbon.Templates.ComboBox | | --- | Fluent.Ribbon.Styles.InRibbonGallery | | --- | Fluent.Ribbon.Styles.RadioButton | | --- | Fluent.Ribbon.Styles.RibbonMenu | | --- | Fluent.Ribbon.Styles.TextBox | | --- | Fluent.Ribbon.Styles.ScrollBar | | --- | Fluent.Ribbon.Styles.StatusBar | | --- | Fluent.Ribbon.Styles.StatusBarMenuItem | | --- | Fluent.Ribbon.Styles.WindowCommands |
Hi, @batzen I think the "Breaking Change" is that I have changed the existing key names. |
Hi @nishy2000 changing something that might have been previously used by users/consumers is a breaking change. You could create a separate PR where you rename the keys and base it off of the branch "features/new_office_theme" instead of the develop branch as the office theme branch is the one i am currently working on features for version 11. |
| Old | New | |-----------------------------------------------|-----------------------------------------------| | --- | Fluent.Ribbon.Styles.ApplicationMenu | | --- | Fluent.Ribbon.Styles.ColorGallery | | --- | Fluent.Ribbon.Styles.ComboBox | | --- | Fluent.Ribbon.Styles.InRibbonGallery | | --- | Fluent.Ribbon.Styles.RadioButton | | --- | Fluent.Ribbon.Styles.RibbonMenu | | --- | Fluent.Ribbon.Styles.TextBox | | --- | Fluent.Ribbon.Styles.ScrollBar | | --- | Fluent.Ribbon.Styles.StatusBar | | --- | Fluent.Ribbon.Styles.StatusBarMenuItem | | --- | Fluent.Ribbon.Styles.WindowCommands |
Hi @batzen Sounds good. I pushed the new commit that does not change the existing key names. Thanks. |
Fix Issue #1177.
I added a style key for the ribbon control.
This is to allow for the creation of custom styles based on the original ribbon control style.
At the same time, key names for styles and templates with different naming conventions have been corrected.Key names added
or changedare as follows.Fluent.Ribbon.Templates.ApplicationMenuButtonFluent.Ribbon.Templates.ApplicationMenuFluent.Ribbon.Styles.RibbonComboButtonFluent.Ribbon.Styles.ComboBox.ToggleButtonFluent.Ribbon.Templates.RibbonComboButtonFluent.Ribbon.Templates.ComboBox.ToggleButtonFluent.Ribbon.Templates.RibbonComboboxFluent.Ribbon.Templates.ComboBox