Set Icon properties as NonLocalizable #1224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@batzen ci build did not run successfully, not sure if you need to invoke something for this. please have a look at PR |
|
Will have a look on Monday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for the issue: #1222
What changed:
Set the [Localizability(LocalizationCategory.NeverLocalize)] and [Localizable(false)] attributes on Icon properties of the controls, so that translation tools do not consider value of Icon property for localizing.
Example:
Before translation
Icon="pack://application:,,,/xxxLibrary;component/Icons/16x16/icnExit.png"
After psuedo translation
Icon="tr_pack://application:,,,/Nmx.Workplace.Library.StyleLibrary;component/Icons/16x16/icnExit.png_tr"