Induce data availability into contract #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noel2004
changed the title
|
Almost done for contract with data availability and handling L1 op (current only depositing and registering),
|
HAOYUatHZ
reviewed
Dec 3, 2021
|
For encoding the priority op of registry user, the gas usage increase to ~330k in registryUser method (before it cost ~90k) |
HAOYUatHZ
reviewed
Dec 3, 2021
| } | ||
| } | ||
|
|
||
| function shiftAndReverseBits16(uint16 val, uint8 offset) |
There was a problem hiding this comment.
can we combine shiftAndReverseBits16, shiftAndReverseBits32, shiftAndReverseBits64, shiftAndReverseBits128?
There was a problem hiding this comment.
tried but failed. If we defined both foo(uint16) and foo(uint32), the calling of foo seems to be considered as ambiguous even you have specified the type of argument explicitly.
added 10 commits
December 28, 2021 13:03
|
Finally all issues have been fixed and contracts now complete work with priority L1 ops. A script for depositing on L1 has also be induced |
noel2004
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR make new contract work with data availability. The encoded tx data would be an argument when submitting block and being verified in the contract. As the result, the signature of submitBlock method has been revised.
For the new implement of submitBlock, some view function is added to facilitate debugging and checking everything is ready without wasting of gas fee.
Note current the original submitBlock method is still being kept in the contract under the name
submitBlockLegacyin case we still need it for some legacy task or compare the gas usage. This need to be removed before the contract is officially released.