Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove local TS types #3

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

cap10morgan
Copy link

@cap10morgan cap10morgan commented Mar 19, 2024

...in favor of the ones generated in the @fluree/crypto lib now.

These will be in dist/fluree-crypto.d.ts now when that library is built. And they are autogenerated by the TS compiler so should stay synced with code changes.

The @fluree/crypto package.json file points at that so they should get automatically picked up by TS tooling.

...in favor of the ones generated in the @fluree/crypto lib now.
Copy link
Author

cap10morgan commented Mar 19, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@cap10morgan cap10morgan requested review from aaj3f and a team March 19, 2024 15:45
Copy link

@dpetran dpetran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Author

@cap10morgan cap10morgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might make sense to wait to merge this until it depends on the next release of @fluree/crypto that contains the generated types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants