-
Notifications
You must be signed in to change notification settings - Fork 758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add rotation to ios #540
Conversation
I think this should be added to this file instead: https://github.com/flutter-ml/google_ml_kit_flutter/blob/master/packages/google_mlkit_commons/ios/Classes/MLKVisionImage%2BFlutterPlugin.m#L6-L18 |
Done :) |
This changes are breaking the example app. I will need to revert them. Please submit another PR and make sure our example app works correctly with all the APIs. Look at this code to include all the possible rotations and camera lens options. Your switch case does not include all of them: https://developers.google.com/ml-kit/vision/face-detection/ios#2.-prepare-the-input-image It should be something like this:
|
Sure. Should the rotation be determined using the device orientation directly on obj-c or using the rotation parameter that is sent in the metadata through the channel? |
Add the rotation functionality to iOS. It rotates the image with the given rotation parameter from the InputImage metadata. I use it to rotate the image when the camera in flutter is locked to "portrait up".