Fix point up event #100
Open
Fix point up event #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a PointUp(mouse up) event is sent, it must include information about the currently pressed button.
JSUYA
reviewed
Jun 16, 2025
| @@ -277,10 +280,11 @@ void FlutterTizenView::OnPointerUp(double x, | |||
| int32_t device_id) { | |||
| if (button != 0) { | |||
| PointerState* state = GetOrCreatePointerState(device_kind, device_id); | |||
| state->buttons &= ~button; | |||
| FlutterPointerPhase phase = GetPointerPhaseFromState(state); | |||
| uint64_t clear_button_state = state->buttons & ~button; | |||
There was a problem hiding this comment.
Could you please check this part? This code is identical to the implementation of window. The state of the buttons sent to flutter may be different from the existing one. Will it change the existing behavior or cause problems?
https://github.com/flutter/flutter/blob/master/engine/src/flutter/shell/platform/windows/flutter_windows_view.cc#L267
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a PointUp(mouse up) event is sent, it must include information about the currently pressed button.