Add additional text diagrams demonstrating overflow #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paldepind
force-pushed
the
additional-text-diagrams
branch
from
f0cef0e to
72f3999
Compare
|
The CI shows some errors that, as far as I can tell, are not related to this PR. |
paldepind
force-pushed
the
additional-text-diagrams
branch
from
72f3999 to
757ef09
Compare
gspencergoog
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
gspencergoog
added
the
autosubmit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to this PR: flutter/flutter#139363
Note that in addition to the new diagrams I also changed the "text_ellipsis" diagram. Most notably by adding a border which I think makes it more clear how the text is cut off.
I also deleted the "text" diagram since I found it a bit superfluous and since it wasn't referred to in the text using the diagram in the documentation.