Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move and convert Engine doc assets #249

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Conversation

jtmcdole
Copy link
Contributor

@jtmcdole jtmcdole commented Jul 15, 2024

Part of flutter/flutter#151691

  • Convert png to avif (supported by Safari, Firefox, and Chrome)
  • Convert gif to webp (supported by Safari, Firefox, and Chrome)

Tool used: imagemagick and zsh scripting.

Part of flutter/flutter#151691

- Convert png to avif (supported by Safari, Firefox, and Chrome)
- Convert gif to webp (supported by Safari, Firefox, and Chrome)

Tool used: imagemagick and zsh scripting.
Copy link
Member

@nate-thegrate nate-thegrate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thoroughly analyzed every 1 and 0 in each binary file, and they all look great.

@jtmcdole jtmcdole added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 15, 2024
@auto-submit auto-submit bot merged commit 5da3306 into flutter:main Jul 15, 2024
2 checks passed
@jtmcdole
Copy link
Contributor Author

I spot checked the images with transparency and that's when I switched from ffmpeg to imagemagick. ffmpeg's libav1stv is busted, and AOM was taking forever. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants