Fix index out of range error when animating to a tab (#6455)

flutter · Sep 23, 2023 · 0340fc0 · 0340fc0
1 parent 80f8fb7
commit 0340fc0
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/packages/devtools_app/lib/src/framework/scaffold.dart b/packages/devtools_app/lib/src/framework/scaffold.dart
@@ -148,9 +148,13 @@ class DevToolsScaffoldState extends State<DevToolsScaffold>
     } else if (widget.screens[_tabController!.index].screenId != widget.page) {
       // If the page changed (eg. the route was modified by pressing back in the
       // browser), animate to the new one.
-      final newIndex = widget.page == null
+      var newIndex = widget.page == null
           ? 0 // When there's no supplied page, we show the first one.
           : widget.screens.indexWhere((t) => t.screenId == widget.page);
+      // Ensure the returned index is in range, otherwise set to 0.
+      if (newIndex == -1) {
+        newIndex = 0;
+      }
       _tabController!.animateTo(newIndex);
     }
   }