Add a TODO to investigate chmod

flutter · Nov 1, 2023 · 4a1e9d1 · 4a1e9d1
1 parent 86bd8f0
commit 4a1e9d1
Showing 1 changed file with 11 additions and 6 deletions.
diff --git a/tool/lib/commands/build_release.dart b/tool/lib/commands/build_release.dart
@@ -72,12 +72,17 @@ class BuildReleaseCommand extends Command {
       workingDirectory: repo.devtoolsAppDirectoryPath,
     );
 
-    final canvaskitDir = Directory(
-      path.join(repo.devtoolsAppDirectoryPath, 'build', 'web', 'canvaskit'),
-    );
-    for (final file in canvaskitDir.listSync()) {
-      if (RegExp(r'canvaskit\..*').hasMatch(file.path)) {
-        await processManager.runProcess(CliCommand('chmod 0755 ${file.path}'));
+    // TODO(kenz): investigate if we need to perform a windows equivalent of
+    // `chmod` or if we even need to perform `chmod` for linux / mac anymore.
+    if (!Platform.isWindows) {
+      final canvaskitDir = Directory(
+        path.join(repo.devtoolsAppDirectoryPath, 'build', 'web', 'canvaskit'),
+      );
+      for (final file in canvaskitDir.listSync()) {
+        if (RegExp(r'canvaskit\..*').hasMatch(file.path)) {
+          await processManager
+              .runProcess(CliCommand('chmod 0755 ${file.path}'));
+        }
       }
     }
   }