add note about memory leak

flutter · Aug 25, 2023 · a9db1f8 · a9db1f8
1 parent 4636bd4
commit a9db1f8
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/packages/devtools_app_shared/lib/src/utils/globals.dart b/packages/devtools_app_shared/lib/src/utils/globals.dart
@@ -23,4 +23,5 @@ void setGlobal(Type clazz, Object instance) {
 
 void removeGlobal(Type clazz) {
   globals.remove(clazz);
+  assert(globals[clazz] == null);
 }
diff --git a/packages/devtools_extensions/lib/src/template/devtools_extension.dart b/packages/devtools_extensions/lib/src/template/devtools_extension.dart
@@ -96,17 +96,18 @@ class _DevToolsExtensionState extends State<DevToolsExtension> {
     setGlobal(IdeTheme, IdeTheme());
   }
 
-  void _removeGlobals() {
+  void _shutdown() {
+    (globals[ExtensionManager] as ExtensionManager?)?._dispose();
     removeGlobal(ExtensionManager);
     removeGlobal(ServiceManager);
     removeGlobal(IdeTheme);
   }
 
   @override
-  void dispose() async {
-    extensionManager._dispose();
-    await serviceManager.manuallyDisconnect();
-    _removeGlobals();
+  void dispose() {
+    // TODO(https://github.com/flutter/flutter/issues/10437): dispose is never
+    // called on hot restart, so these resources leak for local development.
+    _shutdown();
     super.dispose();
   }