Drop unneeded library directives (#6815)

*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.* *List which issues are fixed by this PR.* *Please add a note to `packages/devtools_app/release_notes/NEXT_RELEASE_NOTES.md` if your change requires release notes. Otherwise, add the 'release-notes-not-required' label to the PR.* ![build.yaml badge] If you need help, consider asking for help on [Discord]. [build.yaml badge]: https://github.com/flutter/devtools/actions/workflows/build.yaml/badge.svg
flutter · Nov 22, 2023 · b9c3de7 · b9c3de7
1 parent 6fcd698
commit b9c3de7
Show file tree

Hide file tree

Showing 21 changed files with 17 additions and 37 deletions.
diff --git a/packages/analysis_options.yaml b/packages/analysis_options.yaml
@@ -126,6 +126,7 @@ linter:
     - unnecessary_const
     - unnecessary_getters_setters
     # - unnecessary_lambdas # https://github.com/dart-lang/linter/issues/498
+    - unnecessary_library_directive
     - unnecessary_new
     - unnecessary_null_aware_assignments
     - unnecessary_null_in_if_null_operators
@@ -138,6 +139,7 @@ linter:
     - use_rethrow_when_possible
     # - use_setters_to_change_properties # not yet tested
     # - use_string_buffers # https://github.com/dart-lang/linter/pull/664
+    - use_string_in_part_of_directives
     # - use_to_and_as_if_applicable # has false positives, so we prefer to catch this by code-review
     - valid_regexps
     # - void_checks # not yet tested

diff --git a/packages/devtools_app/lib/src/screens/inspector/inspector_controller.dart b/packages/devtools_app/lib/src/screens/inspector/inspector_controller.dart
@@ -12,8 +12,7 @@
 /// with some refactors to make the code more of a controller than a combination
 /// of view and controller. View specific portions of InspectorPanel.java have
 /// been moved to inspector.dart.
-
-library inspector_controller;
+library;
 
 import 'dart:async';
 

diff --git a/packages/devtools_app/lib/src/screens/inspector/inspector_tree_controller.dart b/packages/devtools_app/lib/src/screens/inspector/inspector_tree_controller.dart
@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-library inspector_tree;
-
 import 'dart:async';
 import 'dart:collection';
 import 'dart:math';

diff --git a/packages/devtools_app/lib/src/screens/provider/instance_viewer/eval.dart b/packages/devtools_app/lib/src/screens/provider/instance_viewer/eval.dart
@@ -3,8 +3,7 @@
 // found in the LICENSE file.
 
 /// A few utilities related to evaluating dart code
-
-library eval;
+library;
 
 import 'dart:async';
 

diff --git a/packages/devtools_app/lib/src/service/service_extensions.dart b/packages/devtools_app/lib/src/service/service_extensions.dart
@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-library service_extensions;
-
 import 'package:devtools_app_shared/service_extensions.dart' as extensions;
 import 'package:flutter/material.dart';
 

diff --git a/packages/devtools_app/lib/src/service/vm_service_wrapper.dart b/packages/devtools_app/lib/src/service/vm_service_wrapper.dart
@@ -4,7 +4,6 @@
 
 // Code needs to match API from VmService.
 // ignore_for_file: avoid-dynamic
-library vm_service_wrapper;
 
 import 'dart:async';
 import 'dart:convert';

diff --git a/packages/devtools_app/lib/src/shared/analytics/_analytics_stub.dart b/packages/devtools_app/lib/src/shared/analytics/_analytics_stub.dart
@@ -5,7 +5,6 @@
 // Avoid unused parameters does not play well with conditional imports.
 // ignore_for_file: avoid-unused-parameters
 // ignore_for_file: avoid-redundant-async
-library _analytics_stub;
 
 import 'dart:async';
 

diff --git a/packages/devtools_app/lib/src/shared/analytics/_analytics_web.dart b/packages/devtools_app/lib/src/shared/analytics/_analytics_web.dart
@@ -2,11 +2,11 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-@JS()
-library gtags;
-
 // ignore_for_file: non_constant_identifier_names
 
+@JS()
+library;
+
 import 'dart:async';
 
 import 'package:devtools_app_shared/ui.dart';

diff --git a/packages/devtools_app/lib/src/shared/analytics/gtags.dart b/packages/devtools_app/lib/src/shared/analytics/gtags.dart
@@ -2,11 +2,11 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-@JS()
-library gtags;
-
 // ignore_for_file: non_constant_identifier_names
 
+@JS()
+library;
+
 import 'package:flutter/foundation.dart';
 import 'package:js/js.dart';
 

diff --git a/packages/devtools_app/lib/src/shared/console/eval/inspector_tree.dart b/packages/devtools_app/lib/src/shared/console/eval/inspector_tree.dart
@@ -7,8 +7,7 @@
 /// This library must not have direct dependencies on web-only libraries.
 ///
 /// This allows tests of the complicated logic in this class to run on the VM.
-
-library inspector_tree;
+library;
 
 import 'package:devtools_app_shared/ui.dart';
 import 'package:flutter/foundation.dart';

diff --git a/packages/devtools_app/lib/src/shared/http/_http_cookies.dart b/packages/devtools_app/lib/src/shared/http/_http_cookies.dart
@@ -20,7 +20,7 @@
 // ignore_for_file: unused_element
 // ignore_for_file: unused_local_variable
 
-part of http;
+part of 'http.dart';
 
 class Cookie {
   String? _name;

diff --git a/packages/devtools_app/lib/src/shared/http/_http_date.dart b/packages/devtools_app/lib/src/shared/http/_http_date.dart
@@ -17,7 +17,7 @@
 // ignore_for_file: unused_local_variable
 // ignore_for_file: avoid-throw-in-catch-block
 
-part of http;
+part of 'http.dart';
 
 // TODO(jacobr): cleanup this class with only static members.
 // ignore: avoid_classes_with_only_static_members

diff --git a/packages/devtools_app/lib/src/shared/http/_http_exception.dart b/packages/devtools_app/lib/src/shared/http/_http_exception.dart
@@ -4,7 +4,7 @@
 
 // This code was pulled from dart:io.
 
-part of http;
+part of 'http.dart';
 
 class HttpException {
   const HttpException(this.message, {this.uri});

diff --git a/packages/devtools_app/lib/src/shared/http/http.dart b/packages/devtools_app/lib/src/shared/http/http.dart
@@ -3,8 +3,7 @@
 // found in the LICENSE file.
 
 /// This library contains code pulled from dart:io that is not platform specific.
-
-library http;
+library;
 
 part '_http_cookies.dart';
 part '_http_date.dart';

diff --git a/packages/devtools_app/lib/src/shared/ui/icons.dart b/packages/devtools_app/lib/src/shared/ui/icons.dart
@@ -9,8 +9,7 @@
 /// to handle the actual platform specific icon rendering.
 /// The benefit of this approach is that icons can be const objects and tests
 /// of code that uses icons can run on the Dart VM.
-
-library icons;
+library;
 
 import 'package:devtools_app_shared/ui.dart';
 import 'package:flutter/material.dart';

diff --git a/packages/devtools_app/test/legacy_integration_tests/debugger.dart b/packages/devtools_app/test/legacy_integration_tests/debugger.dart
@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-library debugger;
-
 import 'package:devtools_shared/devtools_test_utils.dart';
 import 'package:flutter_test/flutter_test.dart';
 

diff --git a/packages/devtools_app/test/test_infra/matchers/matchers.dart b/packages/devtools_app/test/test_infra/matchers/matchers.dart
@@ -4,12 +4,11 @@
 
 // ignore_for_file: avoid_print
 
-library matchers;
-
 import 'dart:io' as io;
 
 import 'package:devtools_app/src/shared/diagnostics/diagnostics_node.dart';
 import 'package:flutter_test/flutter_test.dart';
+
 import '_golden_matcher_io.dart'
     if (dart.library.js_interop) '_golden_matcher_web.dart' as golden_matcher;
 

diff --git a/packages/devtools_extensions/lib/api.dart b/packages/devtools_extensions/lib/api.dart
@@ -2,7 +2,5 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-library api;
-
 export 'src/api/api.dart';
 export 'src/api/model.dart';
diff --git a/packages/devtools_extensions/lib/devtools_extensions.dart b/packages/devtools_extensions/lib/devtools_extensions.dart
@@ -2,6 +2,4 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-library template;
-
 export 'src/template/devtools_extension.dart';
diff --git a/packages/devtools_extensions/lib/utils.dart b/packages/devtools_extensions/lib/utils.dart
@@ -2,6 +2,4 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-library utils;
-
 export 'src/utils.dart';
diff --git a/third_party/packages/widget_icons/lib/widget_icons.dart b/third_party/packages/widget_icons/lib/widget_icons.dart
@@ -4,8 +4,6 @@
 
 // ignore_for_file: constant_identifier_names
 
-library widget_icons;
-
 import 'package:flutter/material.dart';
 import 'package:flutter/widgets.dart';