Initial commit for package:devtools_extensions
#6055
Conversation
kenzieschmoll
requested review from
bkonyi and
polina-c
and removed request for
a team
| static DevToolsExtensionEvent pong = | ||
| DevToolsExtensionEvent(DevToolsExtensionEventType.pong); | ||
|
|
||
| final DevToolsExtensionEventType type; |
There was a problem hiding this comment.
What's the point to differentiate types of extensions if they behave equally?
There was a problem hiding this comment.
Each extension will share some underlying framework for integration with DevTools (connection to DevTools, connection to a VM service, etc.), but the functionality that each extension provides will be entirely dependent on the use case a package or extension author addresses.
|
|
||
| /// Data model for a devtools extension event that will be sent and received | ||
| /// over 'postMessage' between DevTools and the embedded extension iFrame. | ||
| class DevToolsExtensionEvent { |
There was a problem hiding this comment.
Can you explain in doc comment why the events are needed, and how they are supposed to be used?
There was a problem hiding this comment.
Added a reference to [DevToolsExtensionEventType]. This code is incomplete right now since we are starting with the ping, pong support, but in the future we will also support events like connectToVmService, maybe showNotification etc. When we support more events, the DevToolsExtensionEventType enum will be self documenting.
| @@ -0,0 +1,18 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
Does this file need to be included?
There was a problem hiding this comment.
we include the .iml file for the other packages devtools_app, devtools_shared, devtools_test, so following that pattern and including this one as well.
|
|
||
| dependencies: | ||
| flutter: | ||
| sdk: flutter |
There was a problem hiding this comment.
I'm assuming we plan on exposing widgets / ValueNotifiers through this package?
There was a problem hiding this comment.
Yeah, this package will also include a template for extension authors to place at the root of their devtools extension app
This PR adds the
devtools_extensionspackage todevtools/packages/. The initial commit for this package includes some shared data models that will be used by both DevTools and extension authors.work towards #1632.