-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to enable and disable an extension from the extension screen #6140
Add ability to enable and disable an extension from the extension screen #6140
Conversation
@@ -112,50 +124,6 @@ class ExtensionView extends StatelessWidget { | |||
} | |||
} | |||
|
|||
// TODO(kenz): add button to deactivate extension once activate / deactivate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moved to extension_screen_controls.dart
Do we want to be transparent to the user that we will record the answer in the file, so that they know they could save this file in source control? |
If the user does not already have a |
When an extension is loaded for the first time and there is no entry in
devtools_options.yaml
for this extension, an enable prompt will be shown in place of the extension iFrame:The user's answer will be recorded to the
devtools_options.yaml
file by proxy of the devtools server.Once an extension has been enabled, there will be an option to disable the extension from the extension tool header:
When clicked, the user will be asked if they really want to disable the extension. This is preferred because an accidental click here could destroy any state in the extension tool. This also makes the experience less jarring when the screen is removed and the user is navigated back to the DevTools home screen.
This PR also ensures that tabs for extensions are automatically added / removed based on the enabled state for each extension.
Work towards #1632