Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a simulated DevTools environment for developing extensions #6251

Merged
merged 8 commits into from
Aug 25, 2023
Merged

Add a simulated DevTools environment for developing extensions #6251

merged 8 commits into from
Aug 25, 2023

Conversation

kenzieschmoll
Copy link
Member

@kenzieschmoll kenzieschmoll commented Aug 25, 2023 •
edited
Loading

The simulated environment allows the extension to be developed outside of an embedded iFrame environment. It implements the same DevToolsExtensionHostInterface that DevTools does so that:

  • the extension can connect to a vm service uri
  • simulated events can be sent from DevTools to the extension
  • the user can see a log of post messages that go back and forth between the extension and devtools

Screenshot 2023-08-25 at 1 37 09 PM

Work towards #1632
Depends on #6250 landing first.

@kenzieschmoll kenzieschmoll requested a review from a team as a code owner August 25, 2023 13:51
@kenzieschmoll kenzieschmoll requested review from CoderDake and removed request for a team August 25, 2023 13:51
@kenzieschmoll kenzieschmoll mentioned this pull request Aug 25, 2023
Closed
@kenzieschmoll kenzieschmoll mentioned this pull request Aug 25, 2023
Merged
@polina-c
Copy link
Contributor

Do we have a doc page under construction that explains how to author extensions?
It would be helpful to create a draft and fine tune it with every such PR, as it will help reviewers to understand the change better and, as side effect, we will have ready to publish guidance.

polina-c
polina-c reviewed Aug 25, 2023
View reviewed changes
packages/devtools_app_shared/lib/src/ui/common.dart

/// An extension on [ScrollController] to facilitate having the scrolling widget
/// auto scroll to the bottom on new content.
extension ScrollControllerAutoScroll on ScrollController {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool!

@kenzieschmoll
Copy link
Member Author

Do we have a doc page under construction that explains how to author extensions?

Working on that now. Follow up PR coming soon :)

@kenzieschmoll kenzieschmoll merged commit fed0d0b into flutter:master Aug 25, 2023
15 checks passed
@kenzieschmoll kenzieschmoll deleted the ext-sim branch August 25, 2023 23:24
@polina-c polina-c mentioned this pull request Aug 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CoderDake CoderDake CoderDake approved these changes

@polina-c polina-c polina-c approved these changes

Assignees
No one assigned
Labels
release-notes-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenzieschmoll @polina-c @CoderDake