Add showNotification and showBannerMessage to extension API
#6276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkonyi
reviewed
Aug 29, 2023
packages/devtools_extensions/example/foo_devtools_extension/lib/main.dart
Show resolved
Hide resolved
| @@ -53,3 +53,79 @@ class DevToolsExtensionEvent { | |||
|
|
|||
| /// A void callback that handles a [DevToolsExtensionEvent]. | |||
| typedef ExtensionEventHandler = void Function(DevToolsExtensionEvent event); | |||
|
|
|||
| class ShowNotificationExtensionEvent extends DevToolsExtensionEvent { | |||
There was a problem hiding this comment.
Are these classes accessible to developers? If so, we need documentation for them.
There was a problem hiding this comment.
moved to a file that is not exported to the user. Users should send events through the ExtensionManager. We can always expose later if we need to.
There was a problem hiding this comment.
Update: I missed that we use these classes from devtools_app to parse, so made them public and documented in model.dart
bkonyi
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2023-08-28.at.4.44.38.PM.mov
Work towards #1632