Update Deep link validation UI #6544

hangyujin · 2023-10-17T20:08:20Z

Add notifacation cards, coloum filters, etc

Hooked up with rpc.

Figma: https://www.figma.com/file/5zGvx0fvINUUWsTGZsdAKh/Flutter-deeplinking-in-DevTool?node-id=386%3A57755&mode=dev

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read the Flutter Style Guide recently, and have followed its advice.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or there is a reason for not adding tests.

If you need help, consider asking for help on Discord.

…p-link

2 Update deep_links_controller.dart new mock

…p-link-v2

kenzieschmoll

Done with another pass of comments. Fine for this PR since we are already so deep into review, but in the future, please try to break code up into smaller PRs so that is easier to review and iterate upon :) thanks!

kenzieschmoll · 2023-11-07T21:00:56Z

packages/devtools_app/lib/src/screens/deep_link_validation/deep_link_list_view.dart

-    required this.tableView,
-    required this.controller,
-  });
+    final ColumnData<LinkData> domain = DomainColumn(controller);


This is probably because the type is not specified in the columns parameter below:
columns: <ColumnData>[ ==> columns: <ColumnData<LinkData>>[

and then you should be able to remove the types here

kenzieschmoll · 2023-11-07T21:01:29Z

packages/devtools_app/lib/src/screens/deep_link_validation/deep_link_list_view.dart

-    required this.tableView,
-    required this.controller,
-  });
+    final ColumnData<LinkData> domain = DomainColumn(controller);


That and FlatTable should have a type too: FlatTable<LinkData>

packages/devtools_app/lib/src/screens/deep_link_validation/deep_link_list_view.dart

packages/devtools_app/lib/src/screens/deep_link_validation/deep_links_model.dart

packages/devtools_app/lib/src/screens/deep_link_validation/validation_details_view.dart

…p-link-v2

chunhtai · 2023-11-09T20:54:12Z

packages/devtools_app/lib/src/screens/deep_link_validation/deep_links_controller.dart


 import '../../shared/analytics/analytics.dart' as ga;
 import '../../shared/analytics/constants.dart' as gac;
 import '../../shared/config_specific/server/server.dart' as server;
 import 'deep_links_model.dart';

+const String _apiKey = 'AIzaSyDVE6FP3GpwxgS4q8rbS7qaf6cAbxc_elc';
+const String _assetLinksGenerationURL =


why not use store as URI directly?

I would probably refactor out most of the http related thing into a file

will do it in next pr as kenzie also mentioned this pr is getting too large

chunhtai · 2023-11-09T20:57:57Z

packages/devtools_app/lib/src/screens/deep_link_validation/deep_links_controller.dart

+          _packageNameKey: applicationId,
+          _domainsKey: [selectedLink.value!.domain],
+          // TODO(hangyujin): The fake fingerprints here is just for testing usage, should remove it later.
+          'supplemental_sha256_cert_fingerprints': [


do you know what would happen if not supplied and doesn't have play console project set up? I think most of our customer will use auto sign by play store. They won't be able to provide this finger prints.

if not supplied and doesn't have play console project set up=> the http response will be error

Added a todo here to handle this error case

chunhtai · 2023-11-09T20:59:47Z

packages/devtools_app/lib/src/screens/deep_link_validation/deep_links_controller.dart

+      if (failedChecks != null) {
+        for (final Map<String, dynamic> failedCheck in failedChecks) {
+          switch (failedCheck[_checkNameKey]) {
+            case 'EXISTENCE':


should we turn this into const string?
also should probably move these into a file.

chunhtai · 2023-11-09T21:01:08Z

packages/devtools_app/lib/src/screens/deep_link_validation/deep_links_model.dart

+}
+
+enum DomainError {
+  existence('Domain doesn\'t exist'),


what about other connectivity errors?

will update them later

packages/devtools_app/test/deep_link_vlidation/deep_links_screen_test.dart

chunhtai

LGTM, if my concerns are tracked will be addressed in later prs

auto-submit · 2023-11-09T22:06:17Z

auto label is removed for flutter/devtools/6544, due to - The status or check suite Dart Code Metrics has failed. Please fix the issues identified (or deflake) before re-applying this label.

hangyujin added 24 commits March 9, 2023 17:26

1

87ed955

Merge branch 'master' of https://github.com/flutter/devtools into dee…

354462a

…p-link

http request

139148e

Merge branch 'master' of https://github.com/flutter/devtools into dee…

5a8db98

…p-link

1

703b180

Merge branch 'master' of https://github.com/flutter/devtools into dee…

3269474

…p-link

1

80160f1

2

9d9f5f9

Update deep_links_screen.dart

5b64149

2

de2ecc6

3

9d2892b

update datatable

d849f14

Update deep_links_model.dart

cfea32d

2 Update deep_links_controller.dart new mock

Update deep_links_screen.dart

63f9a2d

update

d3b4ea8

green

808e07b

Update deep_links_screen.dart

ad82412

update

ce1dcc4

Update deep_links_screen.dart

d887fee

1

76daac3

1

ea119c6

Merge branch 'master' of https://github.com/flutter/devtools into dee…

4cbf046

…p-link-v2

update deep link validation tool ui

95c2633

Merge branch 'master' of https://github.com/flutter/devtools into dee…

ed245ee

…p-link-v2

hangyujin requested a review from a team as a code owner October 17, 2023 20:08

hangyujin requested review from CoderDake, chunhtai and a team and removed request for a team October 17, 2023 20:08

hangyujin changed the title ~~Update Deep link validation ui~~ Update Deep link validation UI Oct 17, 2023

rename

5fc40b5

hangyujin requested a review from kenzieschmoll November 7, 2023 19:23

hangyujin added 2 commits November 7, 2023 13:28

Update validation_details_view.dart

f4d545a

Update deep_links_controller.dart

4c83571

kenzieschmoll reviewed Nov 8, 2023

View reviewed changes

hangyujin added 3 commits November 8, 2023 13:55

resolve comments

58f732c

resolve comments

7f5c6d7

Update deep_link_list_view.dart

ef479b1

hangyujin requested a review from kenzieschmoll November 8, 2023 23:17

kenzieschmoll approved these changes Nov 9, 2023

View reviewed changes

hangyujin added the release-notes-not-required label Nov 9, 2023

hangyujin added 6 commits November 8, 2023 17:20

Merge branch 'master' of https://github.com/flutter/devtools into dee…

bb23643

…p-link-v2

lint

0821254

Update deep_links_controller.dart

47540b6

Update deep_links_controller.dart

bf911bf

Update deep_links_screen_test.dart

9e0f937

update tests

ae0c59b

chunhtai reviewed Nov 9, 2023

View reviewed changes

hangyujin added 4 commits November 9, 2023 13:10

Update deep_links_screen_test.dart

e43d150

lint

68bf8b9

add todo

8b86de4

lint

e52ce27

chunhtai approved these changes Nov 9, 2023

View reviewed changes

lint

c199bf9

hangyujin added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 9, 2023

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 9, 2023

lint

634d489

hangyujin merged commit a7d4cf6 into flutter:master Nov 9, 2023
19 checks passed

hangyujin deleted the deep-link-v2 branch February 12, 2024 19:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Deep link validation UI #6544

Update Deep link validation UI #6544

hangyujin commented Oct 17, 2023 •

edited

Loading

kenzieschmoll left a comment

kenzieschmoll Nov 7, 2023

kenzieschmoll Nov 7, 2023

chunhtai Nov 9, 2023

chunhtai Nov 9, 2023

hangyujin Nov 9, 2023

chunhtai Nov 9, 2023

hangyujin Nov 9, 2023

chunhtai Nov 9, 2023

chunhtai Nov 9, 2023

hangyujin Nov 9, 2023

chunhtai left a comment

auto-submit bot commented Nov 9, 2023

Update Deep link validation UI #6544

Update Deep link validation UI #6544

Conversation

hangyujin commented Oct 17, 2023 • edited Loading

Pre-launch Checklist

kenzieschmoll left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chunhtai left a comment

Choose a reason for hiding this comment

auto-submit bot commented Nov 9, 2023

hangyujin commented Oct 17, 2023 •

edited

Loading