Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow --machine/--allow-embedding to be passed to devtools_tool serve #6670

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Allow --machine/--allow-embedding to be passed to devtools_tool serve #6670

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
216e78a
Allow --machine to be passed to devtools_tool serve
DanTup Nov 7, 2023
eb66845
Add allow-embedding
DanTup Nov 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions tool/lib/commands/serve.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ import '../utils.dart';
const _useLocalFlutterFlag = 'use-local-flutter';
const _updatePerfettoFlag = 'update-perfetto';
const _buildAppFlag = 'build-app';
const _machineFlag = 'machine';
const _allowEmbeddingFlag = 'allow-embedding';

/// This command builds DevTools in release mode by running the
/// `devtools_tool build-release` command and then serves DevTools with a
Expand Down Expand Up @@ -53,6 +55,16 @@ class ServeCommand extends Command {
help:
'Whether to build the DevTools app in release mode before starting '
'the DevTools server.',
)
// Flags defined in the server in DDS.
..addFlag(
_machineFlag,
negatable: false,
help: 'Sets output format to JSON for consumption in tools.',
)
..addFlag(
_allowEmbeddingFlag,
help: 'Allow embedding DevTools inside an iframe.',
);
}

Expand Down