Fix a bug where we were unnecessarily calling manualDisconnect
#6700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenzieschmoll
requested review from
CoderDake and
DanTup
and removed request for
a team
DanTup
approved these changes
Nov 9, 2023
Comment on lines
+63
to
+65
| if (serviceConnection.serviceManager.hasConnection) { | ||
| await serviceConnection.serviceManager.manuallyDisconnect(); | ||
| } |
There was a problem hiding this comment.
I'm not too familiar with this, but is it possible we'd have a race here if there is a connection in progress (hasConnection being false so we skip this, but a connection ends up being formed shortly after?)
(if it is possible, I don't know if calling manuallyDisconnect() is the right thing to do to cancel that anyway, so it might be an unrelated issue if there is such an issue)
|
closing this for now since Dart-Code/Dart-Code#4832 has been resolved. If this is causing other issues we can investigate then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found an issue while investigating Dart-Code/Dart-Code#4832 (comment). We do not need to perform a disconnect if there is not already an existing connection.