-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accept project root paths in debug sessions for sidebar #6715
Accept project root paths in debug sessions for sidebar #6715
Conversation
/// - When the version of Dart-Code is from before this field was added | ||
/// - When a debug session was an attach and we didn't know the source | ||
/// - When the program being run is a lose file without any pubspec | ||
String? get projectRootPath; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just to be clear, this is the path that should contain the .dart_tool/
folder?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's the folder where we found the nearest pubspec.yaml
while walking upwards. I think that's always the same thing?
I've updated the comment to mention this explicitly ("The full path to the root of this project (the folder that contains the pubspec.yaml).")
auto label is removed for flutter/devtools/6715, due to - The status or check suite devtools_app integration-test integration_dart2js - flutter - shard 1/3 has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Failure looks like it might be a repeat of #6289 which was thought to be fixed by #6291:
https://github.com/flutter/devtools/actions/runs/6861908888/job/18658577906?pr=6715 Re-running... |
See #6709
Dart-Code will pass a project root* for debug sessions:
* if it's able to compute one - which it always should for the cases we care about, but there are some edge cases that mean the field might be missing.