Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept project root paths in debug sessions for sidebar #6715

Merged
merged 2 commits into from
Nov 14, 2023

Conversation

DanTup
Copy link
Contributor

@DanTup DanTup commented Nov 11, 2023

See #6709

Dart-Code will pass a project root* for debug sessions:

image

* if it's able to compute one - which it always should for the cases we care about, but there are some edge cases that mean the field might be missing.

/// - When the version of Dart-Code is from before this field was added
/// - When a debug session was an attach and we didn't know the source
/// - When the program being run is a lose file without any pubspec
String? get projectRootPath;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just to be clear, this is the path that should contain the .dart_tool/ folder?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the folder where we found the nearest pubspec.yaml while walking upwards. I think that's always the same thing?

I've updated the comment to mention this explicitly ("The full path to the root of this project (the folder that contains the pubspec.yaml).")

@DanTup DanTup added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 14, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 14, 2023
Copy link

auto-submit bot commented Nov 14, 2023

auto label is removed for flutter/devtools/6715, due to - The status or check suite devtools_app integration-test integration_dart2js - flutter - shard 1/3 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@DanTup
Copy link
Contributor Author

DanTup commented Nov 14, 2023

Failure looks like it might be a repeat of #6289 which was thought to be fixed by #6291:

FlutterDriveProcess - Failure Details:
FlutterDriveProcess - Failure in method: Debugger panel
FlutterDriveProcess - ══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞═════════════════
FlutterDriveProcess - The following TestFailure was thrown running a test:
FlutterDriveProcess - Expected: exactly one matching candidate
Unhandled exception:
FlutterDriveProcess -   Actual: _DescendantWidgetFinder:<Found 0 widgets with widget
Exception: Test 'Debugger panel' failed: ══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞═════════════════
FlutterDriveProcess - matching predicate descending from widgets with type "CallStack":
The following TestFailure was thrown running a test:
FlutterDriveProcess - []>
Expected: exactly one matching candidate
FlutterDriveProcess -    Which: means none were found but one was expected
  Actual: _DescendantWidgetFinder:<Found 0 widgets with widget
FlutterDriveProcess - 
matching predicate descending from widgets with type "CallStack":
FlutterDriveProcess - When the exception was thrown, this was the stack:
[]>
FlutterDriveProcess - dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/errors.dart 297:3  throw_
   Which: means none were found but one was expected
FlutterDriveProcess - packages/matcher/src/expect/prints_matcher.dart.js 436:22                    fail

FlutterDriveProcess - packages/matcher/src/expect/prints_matcher.dart.js 433:12                    _expect
When the exception was thrown, this was the stack:
FlutterDriveProcess - packages/matcher/src/expect/prints_matcher.dart.js 368:12                    expect$
dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/errors.dart 297:3  throw_

https://github.com/flutter/devtools/actions/runs/6861908888/job/18658577906?pr=6715

Re-running...

@DanTup DanTup added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 14, 2023
@auto-submit auto-submit bot merged commit 3fb237d into flutter:master Nov 14, 2023
@DanTup DanTup deleted the add-project-root-to-sessions branch November 14, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App release-notes-not-required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants