Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding JsonViewer copy experience, to improve interaction with JSON #7596

Merged
merged 11 commits into from
Apr 17, 2024
Merged

Adding JsonViewer copy experience, to improve interaction with JSON #7596

merged 11 commits into from
Apr 17, 2024

Conversation

CoderDake
Copy link
Contributor

Screen.Recording.2024-04-16.at.3.10.26.PM.mov
  • Add a copy experience to the JsonViewer so that it is easier to pick out a part of the json that you need.
  • Make TextViewer selectable so that you can be even more granular if needed.

Addresses: #4495

@CoderDake CoderDake marked this pull request as ready for review April 16, 2024 19:54
@CoderDake CoderDake requested a review from a team as a code owner April 16, 2024 19:54
@CoderDake CoderDake requested review from polina-c, bkonyi and kenzieschmoll and removed request for a team and polina-c April 16, 2024 19:54
bkonyi
bkonyi approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@bkonyi bkonyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

kenzieschmoll
kenzieschmoll approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member

@kenzieschmoll kenzieschmoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with one question

@CoderDake CoderDake merged commit 48f4773 into flutter:master Apr 17, 2024
23 checks passed
@CoderDake CoderDake mentioned this pull request Apr 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenzieschmoll kenzieschmoll kenzieschmoll approved these changes

@bkonyi bkonyi bkonyi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CoderDake @bkonyi @kenzieschmoll