Alternating colors look nice in tables when embedded in IDE #8498
Conversation
| primaryTextTheme: _devToolsTextTheme(theme, theme.primaryTextTheme), | ||
| textTheme: _devToolsTextTheme(theme, theme.textTheme), | ||
| colorScheme: theme.colorScheme.copyWith( | ||
| surface: backgroundColor, |
There was a problem hiding this comment.
do we really want to override the surface color specified by the darkColorScheme and lightColorScheme definitions?
There was a problem hiding this comment.
For the darkColorScheme and lightColorScheme, the surface color is the same as this backgroundColor. This makes sure that the surface color for IDE themes matches the IDE's background color.
| Color darken({int percent = 10}) { | ||
| assert(1 <= percent && percent <= 100); | ||
| final p = percent / 100; |
There was a problem hiding this comment.
can we make these methods take a value between 0.0 and 1.0 instead of having to / 100 to get the percentage? This is similar to flutter's opacity APIs for example.
| @@ -599,3 +603,23 @@ ButtonStyle _generateButtonStyle({ | |||
| } | |||
| return buttonStyle; | |||
| } | |||
|
|
|||
| extension on Color { | |||
There was a problem hiding this comment.
I see we already have these utilities in devtools_app: https://github.com/flutter/devtools/blob/master/packages/devtools_app/lib/src/shared/common_widgets.dart/#L944
Instead of creating new utility methods here, can we move the existing ones to devtools_app_shared: https://github.com/flutter/devtools/blob/master/packages/devtools_app_shared/lib/src/ui/ui_utils.dart/#L1
| @@ -146,3 +146,33 @@ extension StringUtilities on String { | |||
| return true; | |||
| } | |||
| } | |||
|
|
|||
| /// Utility extension methods to the [Color] class. | |||
| extension ColorExtension on Color { | |||
There was a problem hiding this comment.
can you move this to ui/ui_utils instead? That way we don't have to cross reference utils/ imports from the ui/theme.dart file. We try to keep things separated in this package since it is published and also for BUILD rules in g3.
Fixes #8466
Work towards #8230
Alternating table row colors now match the IDE theme.
DevTools light theme:
DevTools dark theme:
Custom IDE themes:
