Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

License update - Batch 44 #8746

Merged
merged 1 commit into from
Jan 16, 2025
Merged

License update - Batch 44 #8746

merged 1 commit into from
Jan 16, 2025

Conversation

mossmana
Copy link
Contributor

@mossmana mossmana commented Jan 15, 2025 •
edited
Loading

Updates the license headers for:

  1. packages/devtools_app/macos/Flutter/GeneratedPluginRegistrant.swift
  2. packages/devtools_app/macos/README.md
  3. packages/devtools_app/macos/Runner/AppDelegate.swift
  4. packages/devtools_app/macos/Runner/MainFlutterWindow.swift
  5. packages/devtools_app/macos/RunnerTests/RunnerTests.swift

#8216

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read the [Flutter Style Guide] recently, and have followed its advice.
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or there is a reason for not adding tests.

build.yaml badge

mossmana
mossmana commented Jan 15, 2025
View reviewed changes
packages/devtools_app/macos/README.md
Copyright 2025 The Flutter Authors
Use of this source code is governed by a BSD-style license that can be
found in the LICENSE file or at https://developers.google.com/open-source/licenses/bsd.
-->
If macos configuration needs to be regenerated, after regeneration
Copy link
Contributor Author

@mossmana mossmana Jan 15, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are other files like *.plist, *.xcworkspacedata etc. that are also in this directory. They are typically generated. It's not clear which, if any, of the *.swift files are generated. So, including headers on them for now.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds fine. If these are generated files (which I think most, if not all, are), the headers will fall off on the next generation, which should get us into the expected state.

@mossmana mossmana marked this pull request as ready for review January 15, 2025 21:28
@mossmana mossmana requested a review from a team as a code owner January 15, 2025 21:28
@mossmana mossmana requested review from bkonyi and removed request for a team January 15, 2025 21:28
@mossmana mossmana merged commit 8755d5d into flutter:master Jan 16, 2025
23 checks passed
@mossmana mossmana changed the title license update - batch 44 License update - Batch 44 Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenzieschmoll kenzieschmoll kenzieschmoll approved these changes

@bkonyi bkonyi Awaiting requested review from bkonyi bkonyi is a code owner automatically assigned from flutter/devtools-reviewers

Assignees
No one assigned
Labels
release-notes-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mossmana @kenzieschmoll