Fix broken comment references in devtools_app_shared #8863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /// Each child in [children] must have an accompanying header in [header]. Since | ||
| /// each header must be a [PreferredSizeWidget], it is common to use the shared | ||
| /// widgets [AreaPaneHeader] or [BlankHeader] for the column [headers]. | ||
| /// Each child in `children` must have an accompanying header in [headers]. |
There was a problem hiding this comment.
is there a lint to catch these types of errors?
There was a problem hiding this comment.
There is; the comment_references lint. I hope to turn it on after fixing these.
kenzieschmoll
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some broken references were just typos. Some were pointing to properties of non-local types. Some were found on a class's doc comment, while refering to parameters in the constructor, which is not possible to do.